Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove conflicting specifications in filteringTerms #165

Merged

Conversation

mbaudis
Copy link
Member

@mbaudis mbaudis commented Sep 23, 2024

This addresses #159 - see comments there.

This addresses #159 - see comments there.
Copy link
Collaborator

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues on my end.

I'll restate my comments on #161, that these files don't have a clear role in the spec, although I see no harm in cleaning them up.

@mbaudis
Copy link
Member Author

mbaudis commented Sep 27, 2024

I'll restate my comments on #161, that these files don't have a clear role in the spec, although I see no harm in cleaning them up.

Yes; IMO they should be removed in another change - but best in one that provides an overall schema for endpoints (not as OpenAPI, but enabling OpenAPI generation).

@mbaudis mbaudis merged commit 6342540 into schema-urgent-fixes Nov 8, 2024
1 check passed
@mbaudis
Copy link
Member Author

mbaudis commented Nov 8, 2024

Merging this into urgent fixes since not affecting the schema directly. Further cleanup then later.

@costero-e costero-e deleted the remove-conflicting-filteringTerms-definitions branch December 13, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants