Updating develop branch from last urgent fixes to main #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation directories are confusing & not part of the framework itself.
…esponse Removing mentions to "aggregated" granularity in the code.
…mnants removing the validation directories
`ResultsetInstance` was missing the "type" parameter which leads to errors when creating instances.
This is a pure documentation change for the handover format. Addresses #83
The parameter descriptions in the EntryTypeDefinitions schema seem somewhat hard to parse and potentially misleading - this is a go at cleaning them up a bit.
It is not clear how to use ontologyTermForThisType w/o examples (i.e. terms for biosample, individual... - added some but incomplete...) and there is also a logical duplication having a "unique" id and an ontology term. Overall this should be clarified but the current modification seems (a) sensible (step).
Update schema-urgent-fixes branch to align with main
fix wrong "runs", "analyses" entry types in beaconMap
This brings it in line with the hCNV version where it is being maintained (adjustment for VRS official status etc.). See https://cnvar.org/resources/CNV-annotation-standards/
Removing validation files
missing object type fix
updated CNV term mapping table
…readme Update changelog of versions
Editing readme's changelog in order to update version
Update entryTypeDefinition description
for templates the format must be "uri-template".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.