Product quiz TS migration #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdraward
reviewed
Nov 7, 2024
shopify/product-quiz-template/extensions/quiz/assets/product-quiz.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Riley Draward <[email protected]>
…o product-quiz-ts
|
Waiting on Nic to help me with that id issue. (quiz update) |
rdraward
approved these changes
Nov 13, 2024
| @@ -74,7 +79,9 @@ export default ({ | |||
| requiredIndicator | |||
| label="Name" | |||
| autoComplete="off" | |||
| error={errors.quiz?.title?.message} | |||
| error={ | |||
| (errors.quiz as { title?: { message: string } })?.title?.message | |||
There was a problem hiding this comment.
This feels like we should be passing in typing to useFormContext instead of using as here
| @@ -89,7 +96,9 @@ export default ({ | |||
| requiredIndicator | |||
| label="Description" | |||
| autoComplete="off" | |||
| error={errors.quiz?.body?.message} | |||
| error={ | |||
| (errors.quiz as { body?: { message: string } })?.body?.message | |||
There was a problem hiding this comment.
same comment as above, typing on useFormContext vs as
| error={errors.quiz?.questions?.[i]?.text?.message} | ||
| error={ | ||
| ( | ||
| errors.quiz as { |
There was a problem hiding this comment.
same comment, useFormContext typing vs as
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding type declarations and definitions for migration to ts