Blog template TS migration #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdraward
approved these changes
Nov 12, 2024
|
|
||
| // reformat the content field to be a markdown field | ||
| setValue("content", { | ||
| markdown: content, | ||
| }); | ||
| } as any); |
There was a problem hiding this comment.
Instead of doing this, we should be able to type the default value (line 40 of this file)
content: "Start writing your blog post here!" as string | { markdown: string | (string & { markdown: string | null | undefined; }); },
There was a problem hiding this comment.
I'll also try to find a big of time to clean this up before we pivot outside of Shopify apps, it is an icky MDXEditor integration right now
There was a problem hiding this comment.
I tried that type but it didn't seem to work. Not sure what to do in this case. Do you have an suggestions?
There was a problem hiding this comment.
Did you try it on line 40? Seems to work okay here:
https://blog-ts-template-test.gadget.app/edit/development/files/web/components/PostForm.tsx?startLineNumber=40&startColumn=0&endLineNumber=40&endColumn=0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.