Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tailwind-css template TS migration #123

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Tailwind-css template TS migration #123

wants to merge 4 commits into from

Conversation

DevAOC
Copy link
Collaborator

@DevAOC DevAOC commented Nov 11, 2024

No description provided.

@DevAOC DevAOC requested a review from rdraward November 11, 2024 18:26
rdraward
rdraward approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@rdraward rdraward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 ✅
Approving assuming changes to tailwind.config file (make sure to take a quick peek after the update to make sure styles are properly applied)

web/tailwind-css-template/tailwind.config.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not using Tailwind's recommended TypeScript configuration
https://tailwindcss.com/docs/configuration#using-esm-or-type-script

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups, yep! Changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdraward rdraward rdraward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DevAOC @rdraward