Skip to content

Commit

Permalink
Merge pull request #841 from galacean/chore/gl-lost-check
Browse files Browse the repository at this point in the history
chore: add gl lost check when framebuffer failed
  • Loading branch information
yiiqii authored Jan 16, 2025
2 parents 200431c + eda133c commit a898434
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/effects-webgl/src/gl-framebuffer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ export class GLFramebuffer extends Framebuffer implements Disposable {
const status = gl.checkFramebufferStatus(gl.FRAMEBUFFER);

if (status !== gl.FRAMEBUFFER_COMPLETE) {
throw new Error(`Framebuffer failed, status: ${status}, error: ${gl.getError()}.`);
throw new Error(`Framebuffer failed. gl status=${status}, gl error=${gl.getError()}, gl isContextLost=${gl.isContextLost()}.`);
}
this.ready = true;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/effects-webgl/src/gl-renderer-internal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export class GLRendererInternal implements Disposable, LostHandler {
addItem(this.framebuffers, framebuffer);
assignInspectorName(fbo, name, name);
} else {
throw new Error('Failed to create WebGL framebuffer');
throw new Error(`Failed to create WebGL framebuffer. gl isContextLost=${this.gl.isContextLost()}`);
}

return fbo;
Expand Down

0 comments on commit a898434

Please sign in to comment.