Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events DataPLANT #2153

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Conversation

sebastian-schaaf
Copy link
Contributor

DataPLANT project connected with EGD '22 (CoFest) and two Freiburg Galaxy courses (Feb + Jun '23) by setting up news' metadata and logos.

package.json Outdated Show resolved Hide resolved
@bgruening
Copy link
Member

Now you are deleting a file :-(

@sebastian-schaaf
Copy link
Contributor Author

Now you are deleting a file :-(

Yes, saw that on the failing tests earlier today (due to missing package.json). However, the file (master branch version) should be back in, and all tests have passed...
Did you check the most recent version of the PR..?

@dannon
Copy link
Member

dannon commented Sep 6, 2023

It looks incorrect to me still. I can rebase this to fix it up; we shouldn't leave the large diff in either way.

@sebastian-schaaf
Copy link
Contributor Author

sebastian-schaaf commented Sep 6, 2023

Thanky for jumping in - and sorry for the trouble, I have no idea why there is still the yarn.lock showing in the diff (making it so large...).
Alternatively I could create an entirely new, clean PR?

@dannon
Copy link
Member

dannon commented Sep 6, 2023

@sebastian-schaaf No worries -- I rebased and it's good to go now. I removed changes to the undesired files during rebase.

@bgruening
Copy link
Member

@dannon this PR is only needed because the supporter's annotations are not rendered. Do you recall if this was ever implemented?

@bgruening bgruening merged commit 79af6ca into galaxyproject:master Sep 7, 2023
3 checks passed
@dannon
Copy link
Member

dannon commented Sep 7, 2023

@bgruening Doesn't look like it is used in any of the templates. How should it look? (I mean, I guess it should look like what's in the PR here, but do we have a list of supporter key to name+logo+blurb mapping anywhere?)

@bgruening
Copy link
Member

@bgruening
Copy link
Member

It can very well be that this was never implemented and I missed that. Just wanted to ask if this is a bug or a NotImplemented :)

@dannon
Copy link
Member

dannon commented Sep 7, 2023

@bgruening Yeah, I don't see anywhere these are actually handled yet. It shouldn't be a big project to add, though.

paulzierep pushed a commit to paulzierep/galaxy-hub that referenced this pull request Nov 7, 2023
* dataplant + esg logos for workshop July '23

* dataplant + esg supporters tags for workshop July '23

* dataplant + esg support for workshop February '23

* dataplant + esg support for EGD '22 (sub-page/CoFest only)
paulzierep pushed a commit to paulzierep/galaxy-hub that referenced this pull request Nov 28, 2023
* dataplant + esg logos for workshop July '23

* dataplant + esg supporters tags for workshop July '23

* dataplant + esg support for workshop February '23

* dataplant + esg support for EGD '22 (sub-page/CoFest only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants