-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events DataPLANT #2153
Events DataPLANT #2153
Conversation
Now you are deleting a file :-( |
Yes, saw that on the failing tests earlier today (due to missing package.json). However, the file (master branch version) should be back in, and all tests have passed... |
It looks incorrect to me still. I can rebase this to fix it up; we shouldn't leave the large diff in either way. |
891758c
to
4e13cd3
Compare
Thanky for jumping in - and sorry for the trouble, I have no idea why there is still the yarn.lock showing in the diff (making it so large...). |
@sebastian-schaaf No worries -- I rebased and it's good to go now. I removed changes to the undesired files during rebase. |
@dannon this PR is only needed because the supporter's annotations are not rendered. Do you recall if this was ever implemented? |
@bgruening Doesn't look like it is used in any of the templates. How should it look? (I mean, I guess it should look like what's in the PR here, but do we have a list of supporter key to name+logo+blurb mapping anywhere?) |
They look like here: https://usegalaxy-eu.github.io/posts/2022/03/13/workflow_commnity_inititive/ And we had defined them here: https://github.com/usegalaxy-eu/website/blob/master/_includes/sponsors.html |
It can very well be that this was never implemented and I missed that. Just wanted to ask if this is a bug or a NotImplemented :) |
@bgruening Yeah, I don't see anywhere these are actually handled yet. It shouldn't be a big project to add, though. |
* dataplant + esg logos for workshop July '23 * dataplant + esg supporters tags for workshop July '23 * dataplant + esg support for workshop February '23 * dataplant + esg support for EGD '22 (sub-page/CoFest only)
* dataplant + esg logos for workshop July '23 * dataplant + esg supporters tags for workshop July '23 * dataplant + esg support for workshop February '23 * dataplant + esg support for EGD '22 (sub-page/CoFest only)
DataPLANT project connected with EGD '22 (CoFest) and two Freiburg Galaxy courses (Feb + Jun '23) by setting up news' metadata and logos.