-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Galaxy EU 15.09.23 climate strike notification #2159
Merged
kysrpex
merged 2 commits into
galaxyproject:master
from
pavanvidem:climate-strike-15-sept-2023
Sep 11, 2023
Merged
Galaxy EU 15.09.23 climate strike notification #2159
kysrpex
merged 2 commits into
galaxyproject:master
from
pavanvidem:climate-strike-15-sept-2023
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjaysrikakulam
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
kysrpex
requested changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pavanvidem. If you can change those little details then we'll be ready to merge.
kysrpex
approved these changes
Sep 11, 2023
kysrpex
added a commit
to kysrpex/galaxyproject-galaxy-hub
that referenced
this pull request
Sep 11, 2023
After looking at the outcome of galaxyproject#2159, I think it is very confusing that two banners have the same color and more importantly, that the strike banner has no title. In addition, thinking it twice I think it makes more sense to link to the page specific to the action on Friday rather than the main page of Fridays for Future.
kysrpex
added a commit
to kysrpex/galaxyproject-galaxy-hub
that referenced
this pull request
Sep 11, 2023
After looking at the outcome of galaxyproject#2159, I think it is very confusing that two banners have the same color and more importantly, that the strike banner has no title. In addition, thinking it twice I think it makes more sense to link to the page specific to the action on Friday rather than the main page of Fridays for Future.
kysrpex
added a commit
that referenced
this pull request
Sep 11, 2023
After looking at the outcome of #2159, I think it is very confusing that two banners have the same color and more importantly, that the strike banner has no title. In addition, thinking it twice I think it makes more sense to link to the page specific to the action on Friday rather than the main page of Fridays for Future.
paulzierep
pushed a commit
to paulzierep/galaxy-hub
that referenced
this pull request
Nov 7, 2023
paulzierep
pushed a commit
to paulzierep/galaxy-hub
that referenced
this pull request
Nov 7, 2023
) After looking at the outcome of galaxyproject#2159, I think it is very confusing that two banners have the same color and more importantly, that the strike banner has no title. In addition, thinking it twice I think it makes more sense to link to the page specific to the action on Friday rather than the main page of Fridays for Future.
paulzierep
pushed a commit
to paulzierep/galaxy-hub
that referenced
this pull request
Nov 28, 2023
paulzierep
pushed a commit
to paulzierep/galaxy-hub
that referenced
this pull request
Nov 28, 2023
) After looking at the outcome of galaxyproject#2159, I think it is very confusing that two banners have the same color and more importantly, that the strike banner has no title. In addition, thinking it twice I think it makes more sense to link to the page specific to the action on Friday rather than the main page of Fridays for Future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.