Code

SQLAlchemy 2.0#17180

Code

Closed

jdavcs wants to merge 71 commits intogalaxyproject:devgalaxyproject/galaxy:devfrom jdavcs:dev_sa20jdavcs/galaxy:dev_sa20Copy head branch name to clipboard

+2,092-1,846

Commits

Commits on Mar 5, 2024

• Upgrade SQLAlchemy to 2.0

  Show description for f46d69e
  jdavcs

  committed
  f46d69e

  Copy full SHA for f46d69e

• Remove RemovedIn20Warning from config

  Show description for 5dc6e07
  jdavcs

  committed
  5dc6e07

  Copy full SHA for 5dc6e07

• Update import path for DeclarativeMeta

  jdavcs

  committed
  0b75e55

  Copy full SHA for 0b75e55

• Move declaration of injected attrs into constructor

  Show description for 54578a0
  jdavcs

  committed
  54578a0

  Copy full SHA for 54578a0

• Apply Mapped/mapped_column to model definitions

  Show description for 1f207ec
  jdavcs

  committed
  1f207ec

  Copy full SHA for 1f207ec

• Add typing to JSON columns, fix related mypy errors

  Show description for f8f2400
  jdavcs

  committed
  f8f2400

  Copy full SHA for f8f2400

• Use correct type hints to define common model attrs

  jdavcs

  committed
  eb1aa47

  Copy full SHA for eb1aa47

• Start applying Mapped to relationship definitions in the model

  jdavcs

  committed
  ab406e7

  Copy full SHA for ab406e7

• Remove column declaration from HasTags parent class

  jdavcs

  committed
  3441e96

  Copy full SHA for 3441e96

• Fix SA2.0 error: wrap sql in text()

  jdavcs

  committed
  84f9fb7

  Copy full SHA for 84f9fb7

• Fix SA2.0 error: pass bind to create_all

  jdavcs

  committed
  595af2e

  Copy full SHA for 595af2e

• Fix SA2.0 error: use Row._mapping for keyed attribute access

  Show description for d08a047
  jdavcs

  committed
  d08a047

  Copy full SHA for d08a047

• Fix SA2.0 error: show password in url

  Show description for 03ad73c
  jdavcs

  committed
  03ad73c

  Copy full SHA for 03ad73c

• Fix SA2.0 error: use attribute_keyed_dict

  Show description for 0c46858
  jdavcs

  committed
  0c46858

  Copy full SHA for 0c46858

• Fix SA2.0 error: make select stmt a subquery

  Show description for b9d2886
  jdavcs

  committed
  b9d2886

  Copy full SHA for b9d2886

• Fix SA2.0 error: explicitly use subquery() for select-from argument

  jdavcs

  committed
  6b3bca4

  Copy full SHA for 6b3bca4

• Fix SA2.0 error: replase session.bind with session.get_bind()

  jdavcs

  committed
  d478e08

  Copy full SHA for d478e08

• Fix SA2.0 error: joinedload does not take str args

  jdavcs

  committed
  2d49d69

  Copy full SHA for 2d49d69

• Fix use of table model attribute

  Show description for fb526d4
  jdavcs

  committed
  fb526d4

  Copy full SHA for fb526d4

• Fix bug: fix HistoryAudit model

  Show description for e2ded65
  jdavcs

  committed
  e2ded65

  Copy full SHA for e2ded65

• Fix bug: check if template.fields is not null before iterating

  jdavcs

  committed
  d679453

  Copy full SHA for d679453

• Fix bug: call unique() on result, not select stmt

  jdavcs

  committed
  1551a23

  Copy full SHA for 1551a23

• Fix bug: do not pass subquery to in_

  jdavcs

  committed
  fbdfaa6

  Copy full SHA for fbdfaa6

• Fix bug/typo: use select_from

  jdavcs

  committed
  3883f34

  Copy full SHA for 3883f34

• Fix bug: if using alias on ORM entity, use __table__ as valid FromClause

  jdavcs

  committed
  4a8cf03

  Copy full SHA for 4a8cf03

• Fix bug: HDAH model is not serializable (caught by mypy)

  jdavcs

  committed
  efce1c7

  Copy full SHA for efce1c7

• Fix typing error: migrations.base

  jdavcs

  committed
  f6b2269

  Copy full SHA for f6b2269

• Fix typing error: managers.secured

  Show description for 28b25ea
  jdavcs

  committed
  28b25ea

  Copy full SHA for 28b25ea

• Fix typing error: session type

  jdavcs

  committed
  0f4ad52

  Copy full SHA for 0f4ad52

• Fix typing error: use Session instead of scoped_session

  Show description for 36f3051
  jdavcs

  committed
  36f3051

  Copy full SHA for 36f3051

• Fix typing error: sharable

  jdavcs

  committed
  6dde02f

  Copy full SHA for 6dde02f

• Fix SA2.0 error: sqlalchemy exceptions import; minor mypy fix

  jdavcs

  committed
  5aca5b4

  Copy full SHA for 5aca5b4

• Mypy: type-ignore: this is never SessionlessContext

  jdavcs

  committed
  e8a9e6e

  Copy full SHA for e8a9e6e

• Mypy: use verbose assignment to help mypy

  jdavcs

  committed
  25d91eb

  Copy full SHA for 25d91eb

• Mypy: add assert stmt

  jdavcs

  committed
  1a2eb39

  Copy full SHA for 1a2eb39

• Mypy: add assert to ensure seesion is not None

  Show description for f960416
  jdavcs

  committed
  f960416

  Copy full SHA for f960416

• Mypy: return 0 if no results

  jdavcs

  committed
  4c2b4d6

  Copy full SHA for 4c2b4d6

• Mypy: type-ignore: scoped_session vs. install_model_session

  Show description for dd090bf
  jdavcs

  committed
  dd090bf

  Copy full SHA for dd090bf

• Mypy: refactor to one-liner

  jdavcs

  committed
  fae5ed7

  Copy full SHA for fae5ed7

• Mypy: add assert stmts where we know session returns an object

  jdavcs

  committed
  2270d17

  Copy full SHA for 2270d17

• Mypy: rename wfi_step > wfi_step_sq when it becomes a subquery

  jdavcs

  committed
  ddb3101

  Copy full SHA for ddb3101

• Job search refactor: factor out build_job_subquery

  jdavcs

  committed
  4e84e83

  Copy full SHA for 4e84e83

• Job search refactor: build_stmt_for_hda

  jdavcs

  committed
  295da0c

  Copy full SHA for 295da0c

• Job search refactor: build_stmt_for_ldda

  jdavcs

  committed
  78f26fd

  Copy full SHA for 78f26fd

• Job search refactor: build_stmt_for_hdca

  jdavcs

  committed
  03925e2

  Copy full SHA for 03925e2

• Job search refactor: build_stmt_for_dce

  jdavcs

  committed
  ad9023c

  Copy full SHA for ad9023c

• Job search refactor: rename query >> stmt

  jdavcs

  committed
  55dd20f

  Copy full SHA for 55dd20f

• Mypy: add anno for Lists; type-ignore for HDAs

  Show description for 7d4a467
  jdavcs

  committed
  7d4a467

  Copy full SHA for 7d4a467

• Mypy: managers.histories

  jdavcs

  committed
  c794851

  Copy full SHA for c794851

• Mypy: model.deferred

  jdavcs

  committed
  bc329c5

  Copy full SHA for bc329c5

• Mypy: arg passed to template can be None

  jdavcs

  committed
  c84f52b

  Copy full SHA for c84f52b

• Mypy: celery tasks

  Show description for 51d9493
  jdavcs

  committed
  51d9493

  Copy full SHA for 51d9493

• Mypy: type-ignore hda attr-defined error

  Show description for f19f65b
  jdavcs

  committed
  f19f65b

  Copy full SHA for f19f65b

• Convert visualization manager index query to SA Core

  jdavcs

  committed
  41b737f

  Copy full SHA for 41b737f

• Mypy: session is not none

  jdavcs

  committed
  3bb43ec

  Copy full SHA for 3bb43ec

• Mypy: type-ignore what requires more refactoring

  jdavcs

  committed
  9b4080a

  Copy full SHA for 9b4080a

• Mypy: type-ignore hda, ldda attrs: need declarative mapping

  Show description for 575279e
  jdavcs

  committed
  575279e

  Copy full SHA for 575279e

• Mypy: type-ignores to handle late evaluation of relationship arguments

  jdavcs

  committed
  a541a10

  Copy full SHA for a541a10

• Mypy: type-ignore column property assignments (type is correct)

  jdavcs

  committed
  c58ff73

  Copy full SHA for c58ff73

• Mypy: typing errors, misc. fixes

  jdavcs

  committed
  c1ec3ae

  Copy full SHA for c1ec3ae

• Mypy: all statements are reachable

  jdavcs

  committed
  69581d1

  Copy full SHA for 69581d1

• Mypy: need to map hda declaratively, then its parent is model.Base

  jdavcs

  committed
  6396eff

  Copy full SHA for 6396eff

• Fix typing errors: sharable, secured

  jdavcs

  committed
  6311c37

  Copy full SHA for 6311c37

• Fix package mypy errors

  jdavcs

  committed
  49a2112

  Copy full SHA for 49a2112

• Fix SA2.0 error: celery task

  Show description for acdb9c6
  jdavcs

  committed
  acdb9c6

  Copy full SHA for acdb9c6

• Wrap call to ensure session is closed

  Show description for 036dad5
  jdavcs

  committed
  036dad5

  Copy full SHA for 036dad5

• Ensure session is closed on TS Registry load

  Show description for a701cde
  jdavcs

  committed
  a701cde

  Copy full SHA for a701cde

• Fix SA2.0 error: list arg to select; mypy

  jdavcs

  committed
  8c88bf9

  Copy full SHA for 8c88bf9

• Use NullPool for sqlite engines

  Show description for b644b1d
  jdavcs

  committed
  b644b1d

  Copy full SHA for b644b1d

• Help mypy: job is never None

  jdavcs

  committed
  230c4b4

  Copy full SHA for 230c4b4

• Add Decimal to accpted types by util.nice_size()

  jdavcs

  committed
  fd644c3

  Copy full SHA for fd644c3