Improve typing in FormElement
#19801
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the `currentValue` for a `FormElement` is the appropriate type given `props.type`. Fixes galaxyproject#19500
ahmedhamidawan
force-pushed
the
fix_FormData_console_error
branch
from
a24ec9a to
abbf669
Compare
ahmedhamidawan
changed the title
FormElementFormElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the
currentValuefor aFormElementis the appropriate type givenprops.type.Fixes #19500
How to test the changes?
(Select all options that apply)
License