-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bigbed to gtf converter and tests #19809
Open
d-callan
wants to merge
8
commits into
galaxyproject:dev
Choose a base branch
from
d-callan:bigbed-to-gtf-converter
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3290f7f
bigbed to gtf converter w tests
d-callan edc7aa6
clean up output gtf some for bigbedtogtf converter
d-callan 94d38d2
simplify bigbedtogtf converter some
d-callan 92f3f27
bigbed to gtf converter w tests
d-callan 4a9794a
clean up output gtf some for bigbedtogtf converter
d-callan ddbda74
simplify bigbedtogtf converter some
d-callan 0ac9afa
Merge branch 'bigbed-to-gtf-converter' of github.com:d-callan/galaxy …
d-callan e8ab1cf
improve bigbed to gtf converter tests
d-callan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
clean up output gtf some for bigbedtogtf converter
- Loading branch information
commit edc7aa6b38c8623f1c3aa74344d2d8b7641210e1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you're not using
genePredToGtf
? I don't know if we can trust that 17 year old hand-written bed to gff script ...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was partly trying to be consistent w what was already here. it seemed to me like itd be unexpected as a user if i got a very different gtf vs gff2 file w the same input. but also, i was a little worried that if the incoming file wasnt from ucsc that the genepred intermediate file wouldnt make sense or maybe even work. (im not really confident i know what genepred is tbh) and if we did know the incoming data was from ucsc, why not have a genepred to gtf converter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree these are issues, but realistically I think all bigbeds come from ucsc. That said, I think the bigbed to bed converter was the important one that would have an application, maybe we can wait until there's a reason not to use the pre-built gtfs hosted by ucsc before we proceed here ? If there is an actual application we'll also know if this will all work out correctly.