Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup SCSS to prevent mass re-imports. #19828

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jmchilton
Copy link
Member

These are imported as part of base.scss.

The relevant change is in 0b262c0#diff-f93bafd11ed7133c2cb9ab50021a3d29e5ce689d4292d758daa2ae6353d213ae.

Are there downsides to importing all of base.scss in here? I cannot get my downstream branch in #19377 to compile at all when I use components that import _form-elements.scss now 😢. Can we get away with a lighter import than was done 0b262c0?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@ahmedhamidawan ahmedhamidawan force-pushed the remove_duplicated_import branch from d97fd47 to 598188f Compare March 21, 2025 17:26
@jmchilton jmchilton marked this pull request as ready for review March 24, 2025 14:05
@github-actions github-actions bot added this to the 25.0 milestone Mar 24, 2025
@jmchilton jmchilton changed the title Remove duplicated SCSS imports? Cleanup SCSS to prevent mass re-imports. Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants