Cleanup SCSS to prevent mass re-imports. #19828
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are imported as part of base.scss.
The relevant change is in 0b262c0#diff-f93bafd11ed7133c2cb9ab50021a3d29e5ce689d4292d758daa2ae6353d213ae.
Are there downsides to importing all of base.scss in here? I cannot get my downstream branch in #19377 to compile at all when I use components that import _form-elements.scss now 😢. Can we get away with a lighter import than was done 0b262c0?
How to test the changes?
(Select all options that apply)
License