Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use direct icon references in FormSelectMany.vue. #19829

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

jmchilton
Copy link
Member

I'm getting errors about circular dependencies downstream - this doesn't fix them but it is a positive step in the right direction I think.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton marked this pull request as ready for review March 18, 2025 14:20
@github-actions github-actions bot added this to the 25.0 milestone Mar 18, 2025
@jmchilton jmchilton requested a review from a team March 25, 2025 19:57
Copy link
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've been trying to knock these out every component I work on too.

@ahmedhamidawan ahmedhamidawan merged commit e25e03a into galaxyproject:dev Mar 25, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants