[24.2] Do not reorder options in FormSelect component when multiselect disabled

[jdavcs]

Fix #19804

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[ahmedhamidawan]

Is it just me or is the currently selected value not even being highlighted?:

[jdavcs]

Is it just me or is the currently selected value not even being highlighted?:

You're right! 24.2, on main. It's a different issue though, I think.

[ahmedhamidawan]

There is a problem with the multiselect itself as well as FormSelect being unable to recognize if something is selected if the select values are objects as opposed to strings/numbers etc.

[ahmedhamidawan]

Note that this commit 165cff9 not fix the fact that Multiselect is still unable to track which values are current because it has the prop track-by="value" and value in this case can be an object.

[ahmedhamidawan]

Now, explicitly check if the form select values need to be tracked by ids and it now works as expected; the current value(s) are highlighted and ordered accordingly:

[bernt-matthias]

Results look great, but I wont be able to review this .. I have no clue about the client stuff :(

[ahmedhamidawan]

Also changed the hover highlight for the current option to brand-success from brand-danger which I think makes more sense? Can drop this commit if people are against this.

[jdavcs]

@ahmedhamidawan I really dislike the red as the "this option is selected" indicator. Do we have an option besides green? (maybe a darker shade of gray, so as to highlight the selected item as "different" from unselected items; red/green, to me, is action or event-related as opposed to indicating a difference) If not, green is still better than red, in my opinion.

[ahmedhamidawan]

Maybe this? @jdavcs

[jdavcs]

Maybe this? @jdavcs

Yep, I think that makes it much better!