Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mandatory RO-Crate metadata when exporting #19846

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Mar 19, 2025

[in progress during a hackathon this week]

Problem:

Galaxy RO-Crates do not fully comply with the Workflow Run Crate specification.

Changes:

  • added tests which use rocrate-validator to validate generated RO-Crates, both for history export (base RO-Crate spec) and workflow invocation export (Workflow Run Crate spec)
  • added missing mandatory metadata - name, description, and license in the root dataset of the crate.
    • for history export, it seems difficult to set a useful (non-ambiguous) name, I don't know if it's possible to access the name of the history at this place in the code

Still in progress:

  • checking over existing test functions to see if some can be removed as they might be covered by the validator

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added area/testing area/database Galaxy's database or data access layer area/dependencies labels Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer area/dependencies area/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant