Fix Galaxy ignoring job object_store_id for quota check #19854
Merged
+136
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hah, seems that I came up with the same solution as: #19589 .. minus the test :) |
4 tasks
bernt-matthias
force-pushed
the
fix-is_over_quota
branch
from
42de948 to
ec7a075
Compare
bernt-matthias
commented
Mar 20, 2025
bernt-matthias
force-pushed
the
fix-is_over_quota
branch
from
0998632 to
3ade103
Compare
bernt-matthias
force-pushed
the
fix-is_over_quota
branch
from
36496c0 to
b516c7e
Compare
|
The test errors sure look related |
seems that we ignored the job's object_store_id and only used an (undocumented?) object_store_id param of job destinations.
the destination param should have been considered [here (in both cases)](https://github.com/galaxyproject/galaxy/blob/7ff91d8df65b0f55875167fbbcbb6dedaef99ee0/lib/galaxy/jobs/__init__.py#L1648) already.
bernt-matthias
force-pushed
the
fix-is_over_quota
branch
from
b516c7e to
3276d1c
Compare
makes testing also a lot easier I think
bernt-matthias
force-pushed
the
fix-is_over_quota
branch
from
3276d1c to
d6990b0
Compare
|
Thank you, that's much needed! |
|
This PR was merged without a "kind/" label, please correct. |
|
Should this be backported? I would suggest 24.1. |
|
Really uncomfortable with that, maybe carry that patch if you want to test ? |
Sure. I'm already doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my instance I noticed that (irrespective of
object_store_always_respect_user_selection) quotas for object stores are ignored.To me it seems that we ignored the job's object_store_id and only used an (undocumented?) object_store_id param
of job destinations. In the 2nd commit I completely remove destination parameter, because I think that the destination param should have been considered here (in both cases) already.
Opening against dev for better testing. We probably want to backport this?
xref #19589
How to test the changes?
(Select all options that apply)
License