Fix get_dataset_size for datasets with null file_size column #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ``` Oct 13 14:29:40 galaxy-vgp galaxyctl[2536822]: File "/cvmfs/main.galaxyproject.org/venv/lib/python3.8/site-packages/tpv/core/helpers.py", line 16, in get_dataset_size Oct 13 14:29:40 galaxy-vgp galaxyctl[2536822]: return float(dataset.file_size) Oct 13 14:29:40 galaxy-vgp galaxyctl[2536822]: TypeError: float() argument must be a string or a number, not 'NoneType' ``` There's an underlying bug as well where the job state is final but the file size is unset, but I would always consider it better to use one abstraction level above the database column.
nuwang
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Looks great, thanks @mvdbeek. We still have to wait for a point release before we can do a full integration test: https://github.com/galaxyproject/total-perspective-vortex/actions/runs/6864537601/job/18934017692?pr=66#step:8:167 but the mock tests should do for now.
|
There's no hurry, we've also fixed the underlying bug on the galaxy side in galaxyproject/galaxy#16855 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
There's an underlying bug as well where the job state is final but the file size is unset, but I would always consider it better to use one abstraction level above the database column.