Add to to_dict functions to Destination and TagSetManager classes #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuwang
reviewed
Nov 22, 2023
There was a problem hiding this comment.
@pauldg Would you be able to add a test for this? Something like:
original_entity = # some original entity
serialized_entity = original_entity.to_dict()
deserialized_entity = Entity.from_dict(serialized_entity)
assert deserialized_entity == original_entity
nuwang
reviewed
Jan 15, 2024
tests/test_entity.py
Outdated
| deserialized_destination = Destination.from_dict(loader, serialized_destination) | ||
| # make sure the deserialized destination is the same as the original | ||
| self.assertEqual(deserialized_destination, destination) | ||
| assert deserialized_destination == destination |
There was a problem hiding this comment.
The assertEqual above should do the same thing, so I think it's ok to remove this.
Suggested change
| assert deserialized_destination == destination |
tpv/core/entities.py
Outdated
Comment on lines
612
to
617
| 'min_accepted_cores': self.min_accepted_cores, | ||
| 'min_accepted_mem': self.min_accepted_mem, | ||
| 'min_accepted_gpus': self.min_accepted_gpus, | ||
| 'max_accepted_cores': self.max_accepted_cores, | ||
| 'max_accepted_mem': self.max_accepted_mem, | ||
| 'max_accepted_gpus': self.max_accepted_gpus, |
There was a problem hiding this comment.
This needs to be split I think, otherwise, the superclass method will be aware of its subclasses. The min_accepted related fields should go to the Destination class, and rules should go to the EntityWithRules class.
nuwang
force-pushed
the
dest_to_dict_patch
branch
from
0b611e7
to
1e400f6
Compare
nuwang
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions allow a dict representation of Destination objects which is convenient for example for serializebility