Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove dependency on distutils #553

Merged
merged 6 commits into from
Sep 1, 2024

Conversation

kroq-gar78
Copy link
Contributor

@kroq-gar78 kroq-gar78 commented Sep 1, 2024

This should remove any explicit mentions of distutils and fix installation in Python 3.12.

I'm not super familiar with the packaging system, so there's 2 things I'm not sure about:

@kroq-gar78 kroq-gar78 changed the title Remove dependency on distutils MNT Remove dependency on distutils Sep 1, 2024
@mvdoc
Copy link
Contributor

mvdoc commented Sep 1, 2024

This looks great! Re your questions:

  1. We should just add python 3.12 to the github actions and see whether the tests run
  2. I don't think we'll need to pin setuptools anymore after removing numpy.distutils

@mvdoc
Copy link
Contributor

mvdoc commented Sep 1, 2024

I triggered the test on python 3.12, let's see

@mvdoc mvdoc linked an issue Sep 1, 2024 that may be closed by this pull request
@mvdoc
Copy link
Contributor

mvdoc commented Sep 1, 2024

Alright, everything is green. I tried installing locally with a new conda environment and it works great. I'll merge and release a new version.

Thanks @kroq-gar78 !

@mvdoc mvdoc merged commit 5e91db6 into gallantlab:main Sep 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants