Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose deviceIdentifier #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

rodrigoelp
Copy link

Changes included here:

  • Expose the deviceIdentifier as provided by Bugfender, used to uniquely identify an instance out in the field.

  • Changed the location of the bugfender framework, as node_modules is usually not committed to a build repository, it prevents a commit to be valid across multiple computers. To solve this, the location of the bugfender.framework should be changed from ./node_modules/react-native-bugfender to ./ios/frameworks

  • Included typescript type definitions making the library useful to those doing development with a strongly typed language. This type definition also works as documentation of the code.

  • Updated the readme file to give it a bit more structure and include the same for the deviceIdentifier() method.

@RubenVot
Copy link

RubenVot commented May 1, 2019

Nice work!
Be aware that the last versions of BF will be returning an URL for the device identifier instead of a hash. We are going to include this soon in the official SDK for react native.
We accept PR and feature proposals there as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants