Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1070] Disable File Uploads #1091

Closed
wants to merge 1 commit into from
Closed

Conversation

Meowcenary
Copy link
Collaborator

Disable file uploads by setting max allowed files to zero, max file size to zero bytes, disabling the buttons that are used for file upload, and removing all links to the file upload page. closes #1070

<%= render partial: 'generic_files/upload/agreement' %>
<div class="alert alert-success">
<%= t("sufia.upload.cloud_timeout_message", contact_href: link_to(t("sufia.upload.alert.contact_href_text"), sufia.contact_form_index_path)) %>
<div >
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the other empty view are here to override the views that are provided by sufia

@@ -0,0 +1,14 @@
<div class="col-xs-12 heading-row">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to override the sufia provided view

@@ -1,8 +1,6 @@
$(function () {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling the file upload

Copy link
Collaborator

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. People should still be able to edit (which is what we want, and in an ideal world, want only for librarians but that's ok), right?

Obviously this should not be merged/deployed until the opportune moment.

@Meowcenary
Copy link
Collaborator Author

Works for me. People should still be able to edit (which is what we want, and in an ideal world, want only for librarians but that's ok), right?

Obviously this should not be merged/deployed until the opportune moment.

From what I saw the editing would still work fine. Yes, we're just going to have this ready for when the time comes.

Copy link
Collaborator

@carsonicator carsonicator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Meowcenary . Yes, ideally, we would like to allow edit access only to certain users after these "read-only" changes are made.

@mattbaumann1
Copy link
Collaborator

@Meowcenary went to look at another pull request and noticed this pull request hanging out. Is a review on this still needed?

@fenekku
Copy link
Collaborator

fenekku commented Oct 11, 2022

This PR is just waiting on the go from the decision team to make the transition to Prism before being merged. When it's merged and deployed, DigitalHub new entries will be disabled.

@Meowcenary
Copy link
Collaborator Author

Going to rebase this today since it has been sitting out here for awhile. I don't think there will be conflicts, but better to just stay up to date.

@Meowcenary Meowcenary force-pushed the 1070-disable_uploads branch from 9b992ca to 012805b Compare November 3, 2022 14:38
Disable file uploads by setting max allowed files to zero, max file size
to zero bytes, disabling the buttons that are used for file upload, and
removing all links to the file upload page. closes #1070
@Meowcenary Meowcenary force-pushed the 1070-disable_uploads branch from 012805b to d875963 Compare March 31, 2023 16:36
@Meowcenary
Copy link
Collaborator Author

I just rebased this so it should be good to go whenever we want to disable uploading. I'll test it out after I finish changes for #1117

@Meowcenary Meowcenary closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Develop] Disable Uploads
4 participants