Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key and id properties to ArtefactMetadata model class #1089

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Add key and id properties to ArtefactMetadata model class #1089

merged 5 commits into from
Dec 3, 2024

Conversation

8R0WNI3
Copy link
Member

@8R0WNI3 8R0WNI3 commented Nov 28, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 28, 2024
@8R0WNI3 8R0WNI3 requested a review from TuanAnh17N November 28, 2024 15:08
@8R0WNI3 8R0WNI3 mentioned this pull request Nov 28, 2024
Merged
zkdev
zkdev requested changes Nov 28, 2024
View reviewed changes
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Nov 28, 2024
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 29, 2024
@8R0WNI3 8R0WNI3 requested a review from zkdev November 29, 2024 07:12
ccwienk
ccwienk approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@ccwienk ccwienk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. will leave addressing of my comments up to you

ccwienk
ccwienk requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@ccwienk ccwienk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as to my second set of comments (w.r.t. unittest / guarding against changes: please consider that one)

@8R0WNI3 8R0WNI3 requested a review from ccwienk December 2, 2024 08:22
@8R0WNI3 8R0WNI3 merged commit 859ec5f into master Dec 3, 2024
11 checks passed
@8R0WNI3 8R0WNI3 deleted the 8R0WNI3-key branch December 3, 2024 13:11
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccwienk ccwienk ccwienk approved these changes

@TuanAnh17N TuanAnh17N Awaiting requested review from TuanAnh17N TuanAnh17N is a code owner

@zkdev zkdev Awaiting requested review from zkdev zkdev is a code owner

Assignees
No one assigned
Labels
needs/changes Needs (more) changes needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@8R0WNI3 @ccwienk @zkdev @gardener-robot