Use puppetlabs/apache 0.9.x #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test suite currently fails for this branch - https://travis-ci.org/garethr/garethr-graphite/builds/14325279 It looks like it's just a matter of missing environment variables that are used by the new apache module. Happy to merge this if you could fix the failing tests. Thanks! |
| <Location "/"> | ||
| Header set Access-Control-Allow-Origin "*" | ||
| Header set Access-Control-Allow-Methods "GET, OPTIONS" | ||
| Header set Access-Control-Allow-Headers "origin, authorization, accept" | ||
| SetHandler python-program | ||
| PythonPath "['<%= docroot %>'] + sys.path" | ||
| PythonPath "['<%= @docroot %>'] + sys.path" |
There was a problem hiding this comment.
As far as I can tell this will not work right. There is a non-trivial chance the @docroot will be undefined at the time this template gets evaluated. Probably because the vhost template itself evaluates the custom fragment template (templates within templates). See this issue for discussion: puppetlabs/puppetlabs-apache#450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.