Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to indexmap 2 and hashbrown 0.14 #53

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

xmakro
Copy link

@xmakro xmakro commented Feb 19, 2024

No description provided.

@xmakro
Copy link
Author

xmakro commented Feb 19, 2024

I missed that there was already another PR in flight. The difference of this PR is that it only introduces H: BuildHasher where needed.

@garro95
Copy link
Owner

garro95 commented Feb 20, 2024

Hi and thank you for your contribution.

Like the other PR, this fails to build for no_std targets, that is the reason why I didn't merge #51 yet. I will probably have no choice but to introduce a new default feature "std" like they already do in indexmap v2.

This would likely introduce one more breaking change and the need to create a new major version.

@garro95 garro95 merged commit 4b3c7fb into garro95:master Feb 27, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants