fix: Fix parameters for Gradle command in publish workflow #119
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In YAML, folded-style block scalars (with '>') do not insert new lines... Except when the indentation changes. So we had unexpected new lines separating the parameters from the command. Modifications: Use a literal-style block scalar (with '|') and add backslashes to continue the command. At least it's explicit and there is no surprising behavior. Result: Parameters are properly passed to the Gradle command when executing the publish workflow.
|
If you're curious, for an example of this behavior, try the following YAML in a parser such as https://yaml-online-parser.appspot.com root:
noLineBreak: >
foo
bar
somewhatSurprisingLineBreak: >
foo
bar
preserveLineBreaks: |
foo
bar
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In YAML, folded-style block scalars (with '>') do not insert new lines... Except when the indentation changes. So we had unexpected new lines separating the parameters from the command.
Modifications:
Use a literal-style block scalar (with '|') and add backslashes to continue the command. At least it's explicit and there is no surprising behavior.
Result:
Parameters are properly passed to the Gradle command when executing the publish workflow.