guide: basic auth with JS #40
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slandelle
requested changes
Feb 5, 2025
| HttpProtocolBuilder httpProtocol = http | ||
| .baseUrl("https://api.example.com") | ||
| .acceptHeader("application/json") | ||
| .authorizationHeader(session -> { |
There was a problem hiding this comment.
No, we have a built-in for this https://docs.gatling.io/reference/script/protocols/http/protocol/#authorization.
| ).protocols(httpProtocol); | ||
| } | ||
| } | ||
| //#basic-auth-example |
| .acceptHeader("application/json") | ||
| // Use built-in basicAuth with dynamic credentials from the feeder | ||
| .basicAuth( | ||
| (session) => session.get("username"), |
| val httpProtocol = http | ||
| .baseUrl("https://api.example.com") | ||
| .acceptHeader("application/json") | ||
| .basicAuth({ session -> session.getString("username") }) { session -> session.getString("password") } |
| ) | ||
| ).protocols(httpProtocol) | ||
| } | ||
| //#basic-auth-example |
slandelle
requested changes
Feb 6, 2025
| @@ -38,8 +38,7 @@ export default simulation((setUp) => { | |||
| .acceptHeader("application/json") | |||
| // Use built-in basicAuth with dynamic credentials from the feeder | |||
| .basicAuth( | |||
| (session) => session.get("username"), | |||
| (session) => session.get("password") | |||
| "#{username}", "#{password}" | |||
There was a problem hiding this comment.
single line like in Scala and Kotlin, otherwise it won't be consistent across programming languages.
stb13579
force-pushed
the
guide-basic-auth
branch
from
ff44298 to
8f4e51b
Compare
slandelle
requested changes
Feb 6, 2025
Comment on lines
+29
to
+30
| .basicAuth("#{username}", "#{password}" | ||
| ); |
There was a problem hiding this comment.
Suggested change
| .basicAuth("#{username}", "#{password}" | |
| ); | |
| .basicAuth("#{username}", "#{password}"); |
Comment on lines
+40
to
+41
| .basicAuth( "#{username}", "#{password}" | ||
| ); |
There was a problem hiding this comment.
Suggested change
| .basicAuth( "#{username}", "#{password}" | |
| ); | |
| .basicAuth( "#{username}", "#{password}"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge! This is only for testing a doc tool.