fix(gatsby-telemetry): use windowsHide to not show windows command prompt windows

[pieh]

Description

This is quite weird issue - sometimes on Windows when using default "Command prompt" there would be cmd.exe windows popping up and immediately hiding (see videos in #28233 both from issue author and from me).

I used https://docs.microsoft.com/en-us/sysinternals/downloads/procmon to track down what those actually try to execute and found that it's our repository id getter function:

childProcess.execSync (and all the other similar too) have windowsHide option that is disabled by default, which I flip here to handle the issue.

Seperate issue is that we call it multiple times - just from different processes, so memoization we have in

gatsby/packages/gatsby-telemetry/src/telemetry.ts

Lines 176 to 181 in e797658

	getRepositoryId(): IRepositoryId {
	if (!this.repositoryId) {
	this.repositoryId = _getRepositoryId()
	}
	return this.repositoryId
	}

doesn't address cross process ( which might be fine not to handle, just good to be at least aware of it )

And cherry on cake here is that at least for me - without this windowsHide toggle - I only see those command prompts windows popping up in some cases - in here it seems like after main gatsby develop process dies / get killed

Related Issues

Fixes #28233

[jamo]

Nice catch! (do we want the same to flush.ts?)

[pieh]

Nice catch! (do we want the same to flush.ts?)

We might, but we need to be careful about things like - I encountered sindresorhus/execa#433 when doing preliminary investigation for this issue (which turned out absolutely not related to execa, but first comment does touch on some potential issues with windowsHide, which TBF I didn't get deep into it other than "ok this has potential for issues, don't touch more things than absolutely required without a LOT more research into this"). I think we should be fine here with git execution because this is short command that exits on itself quickly (and also have timeout setting).

So for this PR I think we should not add anything more. Just keep this in back of our heads whenever we encounter another issue of Windows Command Prompt window popping up and disapearing.

[jamo]

Thanks!

[vladar]

Published in [email protected] and [email protected]