Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snakemake workflow makes Titan assume male gender regardless of how config.yaml file is configured. #72

Open
d-henness opened this issue Apr 30, 2019 · 2 comments

Comments

@d-henness
Copy link
Contributor

As far as I can tell, changing the sex option in the config.yaml file does not actually change anything about the calculation. The --gender option does not appear in the shell command for runTitanCNA rule, so titanCNA.R will always use the default gender which is male. Was this intentional? Is there some reason we shouldn't be specifying the gender?

@gavinha
Copy link
Owner

gavinha commented May 7, 2019

Hi @d-henness

You're correct - in the snakemake pipeline the gender/sex options are not currently being used and defaults to male which excludes chrX.

I was in the middle of adding the feature to predict the gender from the ichorCNA analysis so that users can use None if the cohort includes both males and females.

For now, I will enable the user to use male or female but this will not work for cohorts with both.

gavinha added a commit that referenced this issue May 7, 2019
For now, assumes that sample set contains all males or all females but not both. #72
For sample sets with both, please use `male` so that chrX is excluded allelic CN analysis
@d-henness
Copy link
Contributor Author

d-henness commented May 7, 2019

Thank you @gavinha. It would be helpful to allow the workflow to run both of these. Perhaps something could be added to the samples.yaml file such as

samples:
  tumor_sample_1:  /path/to/bam/tumor.bam
  normal_sample_1:  /path/to/bam/normal.bam

pairings:
  tumor_sample_1:  normal_sample_1

gender:
  tumor_sample_1: 'male' 

The gender field could be optional and default to male if not present so as not to interrupt workflows based on older versions. I can make up a pull request for this.

gavinha added a commit that referenced this issue May 11, 2019
An additional rule is added to TitanCNA.snakefile to combine the results of TITAN with ichorCNA. In particular, chrX results from ichorCNA is include for male samples because TitanCNA does not include chrX for males.
Addresses issues #53
To some extent is related to #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants