Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use credential bindings for osrfbuild github token #353

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Dec 4, 2020

The PR removes the action of taking the GITHUB_TOKEN from the filesystem and implements the credentials plugin from Jenkins on it. There is also a testing job generated that check permission and push capabilities running directly on osX nodes: Build Status

Linked to: https://github.com/osrf/chef-osrf/pull/55

@j-rivero j-rivero self-assigned this Dec 4, 2020
@j-rivero j-rivero marked this pull request as ready for review February 25, 2021 15:10
@j-rivero j-rivero marked this pull request as draft February 25, 2021 17:20
@j-rivero j-rivero marked this pull request as ready for review February 26, 2021 17:22
@j-rivero
Copy link
Contributor Author

@scpeters this should allow us to move brew jobs out of master and remove the osrfbuild key and use the token instead.

@j-rivero j-rivero requested a review from scpeters February 26, 2021 17:23
@j-rivero j-rivero requested a review from scpeters June 3, 2021 19:00
@j-rivero
Copy link
Contributor Author

Now that releasing has calm down, I'm interested into merging this one.

@scpeters
Copy link
Contributor

@scpeters
Copy link
Contributor

@scpeters
Copy link
Contributor

the bottle builder currently fails during hub pr checkout step:

Build Status https://build.osrfoundation.org/job/generic-release-homebrew_triggered_bottle_builder/614/label=osx_catalina/

+ hub pr checkout 1269
github.com username: github.com password for  (never stored): Not Found

@scpeters
Copy link
Contributor

testing the opening of a homebrew PR from release.py:

it fails because this job actually expects a Linux machine

++ BREW_PREFIX=/home/linuxbrew/.linuxbrew
++ BREW=/home/linuxbrew/.linuxbrew/bin/brew
++ /home/linuxbrew/.linuxbrew/bin/brew up
./scripts/jenkins-scripts/lib/_homebrew_github_setup.bash: line 22: /home/linuxbrew/.linuxbrew/bin/brew: No such file or directory

we should update the script to use BREW_PREFIX=/usr/local for macOS

@scpeters
Copy link
Contributor

I've redeployed the brew dsl from master in order to build some bottles

@j-rivero
Copy link
Contributor Author

j-rivero commented Dec 7, 2023

Resurrecting this:

Looking into the errors that appeared in the previous testing deployed:

  • hub pr checkout 1269
    github.com username: github.com password for (never stored): Not Found

Somehow the GITHUB_TOKEN setup seems not to work with hub. We probably need to add a testing of hub to the test file to be sure everything is working.

it fails because this job actually expects a Linux machine
++ BREW_PREFIX=/home/linuxbrew/.linuxbrew
++ BREW=/home/linuxbrew/.linuxbrew/bin/brew
++ /home/linuxbrew/.linuxbrew/bin/brew up
./scripts/jenkins-scripts/lib/_homebrew_github_setup.bash: line 22: /home/linuxbrew/.linuxbrew/bin/brew: No such file or directory

This clearly fails because our scripts were prepared to use master (a linux box) to interact with Brew via LinuxBrew. I'm going to revert the change to use master in this first step before we move runs out of it in a second PR.

Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero
Copy link
Contributor Author

This needs update after the works of #1206 . Move to draft.

@j-rivero j-rivero marked this pull request as draft November 15, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants