Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #8

Merged
merged 19 commits into from
Jan 6, 2023
Merged

Fix CI #8

merged 19 commits into from
Jan 6, 2023

Conversation

marcoshuck
Copy link
Collaborator

@marcoshuck marcoshuck commented Dec 22, 2022

Workflow runs are not shown in the same Checks tab of a certain pull request, making it harder to check the current status of a PR, as it forces you to go to two different places in order to validate that tests pass. Let's make them no longer depend between each other.

@marcoshuck marcoshuck self-assigned this Dec 22, 2022
@marcoshuck
Copy link
Collaborator Author

marcoshuck commented Dec 22, 2022

There are two test cases that are failing:

=== RUN   TestSQLOptions
    sql_option_test.go:57: 
        	Error Trace:	/home/runner/work/gz-go/gz-go/repository/sql_option_test.go:57
        	            				/home/runner/work/gz-go/gz-go/repository/suite.go:132
        	            				/home/runner/work/gz-go/gz-go/repository/sql_option_test.go:45
        	Error:      	Received unexpected error:
        	            	Missing IGN_DB_USERNAME env variable. Database connection will not work
        	Test:       	TestSQLOptions
--- FAIL: TestSQLOptions (0.01s)
=== RUN   TestRepository
    sql_repository_test.go:36: 
        	Error Trace:	/home/runner/work/gz-go/gz-go/repository/sql_repository_test.go:36
        	            				/home/runner/work/gz-go/gz-go/repository/suite.go:132
        	            				/home/runner/work/gz-go/gz-go/repository/sql_repository_test.go:11
        	Error:      	Received unexpected error:
        	            	Missing IGN_DB_USERNAME env variable. Database connection will not work
        	Test:       	TestRepository
--- FAIL: TestRepository (0.01s)

But CI seems to be working as expected.

EDIT: It seems that env vars are not being properly assigned. This error is also happening in other repositories.

@marcoshuck marcoshuck requested a review from AlejoAsd December 23, 2022 20:11
@marcoshuck marcoshuck marked this pull request as ready for review December 23, 2022 20:11
@marcoshuck
Copy link
Collaborator Author

Care to approve? @AlejoAsd

.github/workflows/test.yaml Outdated Show resolved Hide resolved
@marcoshuck marcoshuck merged commit 6d6378b into main Jan 6, 2023
@marcoshuck marcoshuck deleted the fix/ci branch January 9, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants