Updates after the removal of Scene3D plugin #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
ahcorde
requested changes
Sep 13, 2022
jennuine
approved these changes
Nov 2, 2022
|
@j-rivero would you be able to address the feedback? |
|
@j-rivero mind taking a look? |
Co-authored-by: Jenn Nguyen <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>
azeey
reviewed
Jun 17, 2024
| </plugin> | ||
| ``` | ||
|
|
||
| `MinimalScene` and `GzSceneManager` are responsible for displaying the 3D scene of our world. | ||
| It has the following properties (most of the GUI plugins have them): | ||
| The `MinimalScene` plugin is responsible for displaying the 3D scene of our world. It has the following properties (most of the GUI plugins have them): |
There was a problem hiding this comment.
Should we keep GzSceneManager here since nothing would work without it? cc @ahcorde
|
We'll go ahead and close this since most of the proposed changes have already been implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: gazebosim/garden-tutorial-party#2015
Following gazebosim/gz-gui#484 (comment)
Updates for https://gazebosim.org/docs/garden/sdf_worlds and the example SDF file: