Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing.md: suggest multi-repo features target main #440

Merged
merged 1 commit into from
May 15, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Adds recommendation about interdependent multi-repository features

Summary

I believe we discussed somewhat recently a recommendation to target interdependent multi-repository features to main instead of release branches since this simplifies CI / automated testing and pull request review, so I've added that recommendation to our contribution guide.

Test it

Preview and proofread the changes

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested review from azeey, mjcarroll and iche033 May 15, 2024 10:21
@scpeters scpeters requested a review from mabelzhang as a code owner May 15, 2024 10:21
@scpeters scpeters merged commit 7be75cb into master May 15, 2024
2 checks passed
@scpeters scpeters deleted the scpeters/multi_repo_main branch May 15, 2024 13:31
azeey pushed a commit to azeey/docs that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants