Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ros2_launch_gazebo.md with a Python launch example and typo fixes/formatting for the XML launch file example #482

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Update ros2_launch_gazebo.md with a Python launch example and typo fixes/formatting for the XML launch file example #482

merged 2 commits into from
Aug 19, 2024

Conversation

david-dorf
Copy link
Contributor

@david-dorf david-dorf commented Aug 12, 2024 •
edited by azeey
Loading

🦟 Bug fix

Fixes #

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@david-dorf
Update ros2_launch_gazebo.md with a Python launch example and typo fi…
f6c7808 
…xes/formatting for the XML launch file example.

Signed-off-by: David Dorf <[email protected]>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 12, 2024
@azeey azeey changed the title Update ros2_launch_gazebo.md with a Python launch example and typo fi… Update ros2_launch_gazebo.md with a Python launch example and typo fixes/formatting for the XML launch file example Aug 12, 2024
@azeey azeey requested a review from caguero August 12, 2024 19:13
@ahcorde ahcorde merged commit 79016ed into gazebosim:master Aug 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@azeey azeey azeey approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang mabelzhang is a code owner

@caguero caguero Awaiting requested review from caguero

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-dorf @azeey @ahcorde