Improve Ionic Ubuntu from-source: memory warning and colcon quoting #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
j-rivero
changed the title
azeey
approved these changes
Sep 3, 2024
azeey
reviewed
Sep 3, 2024
| ```bash | ||
| colcon build --merge-install | ||
| ``` | ||
|
|
||
| To speed up the build process, you could also disable tests by using | ||
|
|
||
| ```bash | ||
| colcon build --cmake-args -DBUILD_TESTING=OFF --merge-install | ||
| colcon build --cmake-args ' -DBUILD_TESTING=OFF' --merge-install |
There was a problem hiding this comment.
I don't think this is necessary on Ubuntu, but okay.
Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>
azeey
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Related gazebosim/gazebo_test_cases#1699 (comment)
Summary
Couple of fixes: quoting for colcon 0bffe42 and memory used and colcon thread reduction 6c2f9dc
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.