Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic/troubleshooting: Document the issue when conda env is at the same directory level as src dir #513

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 14, 2024

🦟 Bug fix

Summary

I've lost 4 hours on this...

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

…me directory level as src dir

Signed-off-by: Martin Pecka <[email protected]>
@peci1 peci1 requested a review from mabelzhang as a code owner September 14, 2024 21:06
@peci1
Copy link
Contributor Author

peci1 commented Sep 14, 2024

The underlying cause seems to be that colcon tries to traverse everything in the folder it is called in, not only in src. As it finds the conda env dir, it applies colcon_python_setup_py to all python packages installed in the env, and it shows that many packages have wrong setup.py's on conda-forge (e.g. adodbapi (part of pywin32) raises ArrayIndexOutOfBounds, or numpy doesn't distribute numpy.distutils submodule on conda, but it is required in its setup.py).

I'm not sure if this is expected behavior of colcon or a bug.

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, what a gnarly problem to face! Thanks for the tip.

@azeey azeey enabled auto-merge (squash) September 26, 2024 14:41
@azeey azeey merged commit a788b84 into gazebosim:master Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants