Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix lcov on Ubuntu Noble (#436)" #441

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

This reverts commit 930e17f (from #436) since it breaks GitHub workflows using Jammy for code coverage (there are still many Ionic packages using Jammy for codecov).

Summary

Revert to unbreak workflows until we can fix things better (see gazebosim/gz-utils#133 for an example failure).

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This reverts commit 930e17f.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from j-rivero as a code owner July 30, 2024 00:17
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jul 30, 2024
@scpeters scpeters merged commit bc2a430 into main Jul 30, 2024
10 checks passed
@scpeters scpeters deleted the scpeters/revert_436 branch July 30, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants