-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FuelClient.cc: include <deque> #213
Conversation
Fixes the Windows build. Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools4 #213 +/- ##
===================================================
- Coverage 77.92% 77.90% -0.03%
===================================================
Files 19 19
Lines 2718 2715 -3
===================================================
- Hits 2118 2115 -3
Misses 600 600
Continue to review full report at Codecov.
|
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
the windows test is failing due to a console error message introduced in #199 ( #199 (comment) ), but I believe this should fail on all platforms. I think the |
This was introduced in #199. Signed-off-by: Steve Peters <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
🦟 Bug fix
Fixes the Windows build.
Summary
The
std::deque
datatype was used in #199, but the Windows compiler seems to have trouble identifying the datatype. Seems like a missing header.https://build.osrfoundation.org/job/ign_fuel-tools-ign-4-win/8/
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge