Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge ign-math6 as of Frustum SWIG to main #363

Merged
merged 18 commits into from
Jan 15, 2022
Merged

Merge ign-math6 as of Frustum SWIG to main #363

merged 18 commits into from
Jan 15, 2022

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jan 6, 2022

➡️ Forward port

Port ign-math6 as of 5201e53 to main

Branch comparison: main...5201e53

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

ahcorde and others added 16 commits October 15, 2021 11:32
@ahcorde @scpeters
AxisAlignedBox: deprecate unimplemented methods (gazebosim#261)
a6b0cff 
Signed-off-by: ahcorde <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
@ahcorde @scpeters
AxisAlignedBox Python interface (gazebosim#262)
000ab21 
Signed-off-by: ahcorde <[email protected]>

* Port extra tests from c++

Signed-off-by: Steve Peters <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
@ahcorde @scpeters
MassMatrix3 Python interface (gazebosim#260)
c732c04 
Signed-off-by: ahcorde <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
@ahcorde @scpeters
Added SphericalCoordinates Python interface (gazebosim#263)
2a6f0ba 
Signed-off-by: ahcorde <[email protected]>

Co-authored-by: Steve Peters <[email protected]>
@ahcorde @scpeters
Cylinder Python interface (gazebosim#274)
742a888 
Signed-off-by: ahcorde <[email protected]>

Co-authored-by: Steve Peters <[email protected]>
@ahcorde @scpeters
Plane Python interfaces (gazebosim#272)
200a7ff 
Signed-off-by: ahcorde <[email protected]>

* Re-enable test expectation

Signed-off-by: Steve Peters <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
@ahcorde @scpeters
Sphere Python interface (gazebosim#277)
3dd836f 
Signed-off-by: ahcorde <[email protected]>

Co-authored-by: Steve Peters <[email protected]>
@ahcorde @scpeters
DiffDriveOdometry Python interface (gazebosim#265)
2f88723 
Signed-off-by: ahcorde <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
@ahcorde @scpeters
Box Python interfaces (gazebosim#273)
074aa53 
Signed-off-by: ahcorde <[email protected]>

* Use tighter tolerance

Signed-off-by: Steve Peters <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
@ahcorde @scpeters
Inertial Python interface (gazebosim#275)
a4d0b1f 
Signed-off-by: ahcorde <[email protected]>

* Enable test by scalar-multiplying on the right
* Create fresh Inertial object and enable all tests

In c++ the test object is recreated in different scopes,
but it was being reused in the python test and accumulating
error.

Signed-off-by: Steve Peters <[email protected]>

Co-authored-by: Steve Peters <[email protected]>
@ahcorde @maryaB-osr @chapulina
Added tutorials for vector, angle, triangle and rotation (gazebosim#249)
33ceeaa 
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: MaryaB <[email protected]>
Co-authored-by: ahcorde <devnull@localhost>
Co-authored-by: Louise Poubel <[email protected]>
@kant
Internal URL fixed (paragraph 266) (gazebosim#279)
f92b793 
Signed-off-by: Darío Hereñú <[email protected]>
@ahcorde @scpeters
OrientedBox Python interface (gazebosim#276)
cbc2a1b 
Signed-off-by: ahcorde <[email protected]>

* Rename [XYZ]Length methods to [xyz]_length

Signed-off-by: Steve Peters <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
@scpeters
AxisAlignedBox: rename some python methods (gazebosim#281)
884d67f 
Rename the [XYZ]Length methods to [xyz]_length to improve
readability. This changes the python API but is ok because
the python bindings for this class have not yet been released.

Signed-off-by: Steve Peters <[email protected]>
@scpeters
quaternion_from_euler example: input degrees (gazebosim#282)
919b511 
It's easier to specify angles in degrees than radians,
so change this example to accept user input in degrees.

Signed-off-by: Steve Peters <[email protected]>
@ahcorde @scpeters
Frustrum Python interface (gazebosim#278)
5201e53 
* Added Frustrum Python interface

Signed-off-by: ahcorde <[email protected]>

* Fix whitespace alignment

Signed-off-by: Steve Peters <[email protected]>

Co-authored-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from chapulina January 6, 2022 20:44
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 6, 2022
@chapulina
Merged 5201e53 into main
b1b1f86 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina force-pushed the merge_6_frustum_py_to_main branch from 62a2483 to b1b1f86 Compare January 14, 2022 00:21
@chapulina
Copy link
Contributor

@scpeters , I synced this branch with main and I'm now fixing the tests. The frustum fix is similar to #344 (comment), i.e. s/pos().y()/y()/. I'm now looking into intertial.

@chapulina
Copy link
Contributor

Ok, I pushed workarounds and commented out a couple of tests in 03f6f29. Left TODOs for me to revisit them after the pybind wrappers are forward-ported.

I think this is good to go with green CI, but do you mind taking a look at the last commit before merging, @scpeters ? Thanks!

@chapulina chapulina marked this pull request as ready for review January 14, 2022 01:24
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #363 (03f6f29) into main (b7825df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          65       65           
  Lines        6131     6131           
=======================================
  Hits         6109     6109           
  Misses         22       22
Impacted Files Coverage Δ
include/ignition/math/AxisAlignedBox.hh 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7825df...03f6f29. Read the comment docs.

@scpeters scpeters merged commit 53c35b4 into gazebosim:main Jan 15, 2022
@scpeters scpeters deleted the merge_6_frustum_py_to_main branch January 15, 2022 00:58
@scpeters
Copy link
Member Author

Ok, I pushed workarounds and commented out a couple of tests in 03f6f29. Left TODOs for me to revisit them after the pybind wrappers are forward-ported.

I think this is good to go with green CI, but do you mind taking a look at the last commit before merging, @scpeters ? Thanks!

looks good, thanks!

@chapulina chapulina mentioned this pull request Jan 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scpeters @chapulina @ahcorde @kant