Change to globbed bazel targets #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ease of non-bazel maintainers lives Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-math8 #652 +/- ##
============================================
+ Coverage 95.71% 95.73% +0.01%
============================================
Files 150 151 +1
Lines 10390 10429 +39
============================================
+ Hits 9945 9984 +39
Misses 445 445 ☔ View full report in Codecov by Sentry. |
mjcarroll
requested review from
scpeters and
adityapande-1995
as code owners
Signed-off-by: Michael Carroll <[email protected]>
shameekganguly
approved these changes
Feb 10, 2025
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
8 tasks
|
it looks like sdformat bazel CI has been failing since this was merged (see gazebosim/sdformat#1544 (comment)) gazebosim/sdformat#1540 sounds similar, but it fails too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until I can test downstream impacts