Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci.yml: run cppcheck, cpplint on noble #478

Merged
merged 1 commit into from
Jan 8, 2025
Merged

ci.yml: run cppcheck, cpplint on noble #478

merged 1 commit into from
Jan 8, 2025

Conversation

Pravin-Dangol
Copy link
Contributor

🦟 Bug fix

Part of gazebo-tooling/release-tools#1222

Summary

Jammy isn't officially supported for Ionic, so move linters to use Noble, starting with cppcheck and cpplint.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@Pravin-Dangol Pravin-Dangol requested a review from caguero as a code owner January 8, 2025 20:57
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Jan 8, 2025
azeey
azeey approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@azeey azeey enabled auto-merge (squash) January 8, 2025 21:57
@azeey azeey merged commit 747b85d into gazebosim:gz-msgs11 Jan 8, 2025
11 checks passed
@scpeters scpeters mentioned this pull request Jan 10, 2025
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@azeey azeey azeey approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pravin-Dangol @azeey @scpeters