Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge: 7 -> main #559

Merged
merged 16 commits into from
Oct 11, 2023
Merged

Merge: 7 -> main #559

merged 16 commits into from
Oct 11, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 10, 2023

➡️ Forward port

Port gz-physics7 to main

Branch comparison: main...gz-physics7

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

iche033 and others added 16 commits August 31, 2023 10:39
Signed-off-by: Addisu Z. Taddese <[email protected]>
)

Fixes a segfault that occurs due to destructors being removed from memory before they're called.
---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
* Cleaning up bullet memory use issues
* Fix Windows warning
* Fix same issue in bullet (non-featherstone) implementation

---------

Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
This sets console verbosity to zero when passing NaN
commands in the test to reduce console spam.

Signed-off-by: Steve Peters <[email protected]>
* Make dartsim/World.hh header private

Signed-off-by: Jose Luis Rivero <[email protected]>

* Remove install CMake code

Signed-off-by: Jose Luis Rivero <[email protected]>

---------

Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
…ties (#556)

* dartsim: Fix sign convention error with contact surface motion velocities

This also enables a test that wasn't running due to a missing define.

* Update to pre4

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #559 (822b8a5) into main (6d61199) will decrease coverage by 0.78%.
The diff coverage is 74.50%.

❗ Current head 822b8a5 differs from pull request most recent head 1445341. Consider uploading reports for the commit 1445341 to get more accurate results

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   76.89%   76.11%   -0.78%     
==========================================
  Files         140      140              
  Lines        7683     7797     +114     
==========================================
+ Hits         5908     5935      +27     
- Misses       1775     1862      +87     
Files Coverage Δ
bullet-featherstone/src/Base.hh 100.00% <100.00%> (ø)
bullet-featherstone/src/SDFFeatures.cc 74.54% <100.00%> (ø)
bullet/src/Base.hh 76.13% <100.00%> (+4.13%) ⬆️
dartsim/src/World.hh 100.00% <ø> (ø)
bullet-featherstone/src/JointFeatures.cc 57.69% <75.00%> (-0.57%) ⬇️
bullet-featherstone/src/FreeGroupFeatures.cc 0.00% <0.00%> (ø)
dartsim/src/SimulationFeatures.cc 47.59% <0.00%> (-47.60%) ⬇️

... and 1 file with indirect coverage changes

@iche033 iche033 merged commit a96beb4 into main Oct 11, 2023
5 of 7 checks passed
@iche033 iche033 deleted the merge_7_main_20231010 branch October 11, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants