Use HIDE_SYMBOLS_BY_DEFAULT

[scpeters]

🎉 New feature

Part of testing gazebosim/gz-cmake#392.

Summary

Test it

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[scpeters]

dartsim/src/Base_TEST.cc has linking errors on Ubuntu

[ 62%] �[32m�[1mLinking CXX executable ../bin/UNIT_Base_TEST�[0m
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: warning: relocation against `_ZTVN2gz7physics7dartsim11SDFFeaturesE' in read-only section `.text._ZN2gz7physics7dartsim11SDFFeaturesC1Ev[_ZN2gz7physics7dartsim11SDFFeaturesC1Ev]'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: in function `BaseClass_SdfConstructionBookkeeping_Test::TestBody()':
/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:165: undefined reference to `gz::physics::dartsim::EntityManagementFeatures::ConstructEmptyWorld(gz::physics::Identity const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:174: undefined reference to `gz::physics::dartsim::SDFFeatures::ConstructSdfModel(gz::physics::Identity const&, sdf::v15::Model const&)'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:181: undefined reference to `gz::physics::dartsim::EntityManagementFeatures::GetLinkCount(gz::physics::Identity const&) const'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:182: undefined reference to `gz::physics::dartsim::EntityManagementFeatures::GetJointCount(gz::physics::Identity const&) const'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:186: undefined reference to `gz::physics::dartsim::EntityManagementFeatures::GetLink(gz::physics::Identity const&, unsigned long) const'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:186: undefined reference to `gz::physics::dartsim::EntityManagementFeatures::GetShapeCount(gz::physics::Identity const&) const'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base_TEST.cc:192: undefined reference to `gz::physics::dartsim::EntityManagementFeatures::GetJoint(gz::physics::Identity const&, unsigned long) const'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: in function `gz::physics::detail::ExtractAPI<gz::physics::detail::ImplementationSelector, gz::physics::FeatureList<gz::physics::Feature> >::Impl<std::integer_sequence<unsigned long, 0ul> >::type<gz::physics::FeaturePolicy<double, 3ul> >::type()':
/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: in function `gz::physics::dartsim::Base::Base()':
/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base.hh:261: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/Base.hh:261: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: in function `gz::physics::GetEngineInfo::Implementation<gz::physics::FeaturePolicy<double, 3ul> >::Implementation()':
/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/GetEntities.hh:46: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o:/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/GetEntities.hh:46: more undefined references to `VTT for gz::physics::dartsim::SDFFeatures' follow
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: in function `gz::physics::dartsim::SDFFeatures::SDFFeatures()':
/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/dartsim/src/SDFFeatures.hh:53: undefined reference to `vtable for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o: in function `gz::physics::detail::ExtractAPI<gz::physics::detail::ImplementationSelector, gz::physics::dartsim::SDFFeatureList>::Impl<std::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul, 6ul> >::type<gz::physics::FeaturePolicy<double, 3ul> >::~type()':
/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: /home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: undefined reference to `VTT for gz::physics::dartsim::SDFFeatures'
/usr/bin/ld: CMakeFiles/UNIT_Base_TEST.dir/src/Base_TEST.cc.o:/home/jenkins/workspace/gz_physics-ci-pr_any-jammy-amd64/gz-physics/include/gz/physics/detail/FeatureList.hh:543: more undefined references to `VTT for gz::physics::dartsim::SDFFeatures' follow
/usr/bin/ld: warning: creating DT_TEXTREL in a PIE
collect2: error: ld returned 1 exit status

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (877b328) 77.91% compared to head (8674b5c) 77.91%.
Report is 1 commits behind head on main.

❗ Current head 8674b5c differs from pull request most recent head cf35e03. Consider uploading reports for the commit cf35e03 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   77.91%   77.91%           
=======================================
  Files         140      140           
  Lines        7766     7766           
=======================================
  Hits         6051     6051           
  Misses       1715     1715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[j-rivero]

dartsim/src/Base_TEST.cc has linking errors on Ubuntu

here we go cf35e03

[scpeters]

dartsim/src/Base_TEST.cc has linking errors on Ubuntu

here we go cf35e03

thanks!

[scpeters]

it's working now thanks to @j-rivero!