Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get bullet version from cmake instead of API #591

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Split out from #574 with acknowledgement to @iche033

Summary

Currently the bullet API is called from a common test to get the bullet version in order to disable portions of a test that require new features of bullet. This moves the version checking to cmake with VERSION_* comparison operators and replaces the bullet API call with a macro defined based on that cmake version comparison.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Adapted from #574 with acknowledgement to Ian Chen.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from iche033 January 18, 2024 22:27
@scpeters scpeters requested review from azeey and mxgrey as code owners January 18, 2024 22:27
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 18, 2024
@scpeters scpeters mentioned this pull request Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (216f174) 78.59% compared to head (f05510d) 78.59%.

Additional details and impacted files
@@             Coverage Diff              @@
##           gz-physics6     #591   +/-   ##
============================================
  Coverage        78.59%   78.59%           
============================================
  Files              140      140           
  Lines             7654     7654           
============================================
  Hits              6016     6016           
  Misses            1638     1638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey removed their request for review January 18, 2024 23:55
@scpeters scpeters merged commit ce40465 into gz-physics6 Jan 19, 2024
14 checks passed
@scpeters scpeters deleted the scpeters/bullet_version_check branch January 19, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants