Add NavSat (GPS) sensor #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dre Westcook <[email protected]>
Signed-off-by: Dre Westcook <[email protected]>
Signed-off-by: Dre Westcook <[email protected]>
Signed-off-by: Dre Westcook <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
force-pushed
the
chapulina/4/navsat
branch
from
409baa1 to
b464cf4
Compare
9 tasks
chapulina
added
the
needs upstream release
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
adlarkin
reviewed
Dec 23, 2021
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Ashton Larkin <[email protected]> Co-authored-by: Ashton Larkin <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
|
Thanks for the review, @adlarkin ! I've addressed all comments |
adlarkin
approved these changes
Jan 4, 2022
chapulina
removed
the
needs upstream release
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-sensors6 #177 +/- ##
================================================
+ Coverage 76.04% 76.55% +0.51%
================================================
Files 27 29 +2
Lines 2763 2871 +108
================================================
+ Hits 2101 2198 +97
- Misses 662 673 +11
Continue to review full report at Codecov.
|
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of
Supersedes
Requires
Required by
Summary
The fork for the original PR (#72) has been removed, so I can't push changes to that PR. I kept @Dotrar's commits in this branch, that's where most of the work is. The bulk of my changes are related to migrating from GPS to NavSat.
I retargeted this PR from Dome to Fortress because the GPS sensor will need to use spherical coordinates (see gazebosim/gz-sim#981).
Test it
Try the
ign-gazeboPR: gazebosim/gz-sim#1248Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸