Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shapes.sdf down to 70% RTF from ~100% after Cone was added #2463

Open
azeey opened this issue Jul 2, 2024 · 5 comments
Open

shapes.sdf down to 70% RTF from ~100% after Cone was added #2463

azeey opened this issue Jul 2, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@azeey
Copy link
Contributor

azeey commented Jul 2, 2024

Environment

  • OS Version: Ubuntu 22.04
  • Source or binary build? binary, 8.5.0

Description

  • Expected behavior: shapes.sdf to have an RTF close to 100%
  • Actual behavior: RTF down to 60%-70%. Removing the cone brings the RTF back to ~100%

Steps to reproduce

  1. Run gz sim shapes.sdf
@azeey azeey added the bug Something isn't working label Jul 2, 2024
@azeey
Copy link
Contributor Author

azeey commented Jul 2, 2024

cc @bperseghetti

@bperseghetti
Copy link
Member

@azeey appears this might also be an issue with mesh shapes in general? If you replace the cone with another ellipsoid it seems to have same slowdown issue, both cone and ellipsoid use meshes for collision instead of closed form solvers, that's my guess for the issue?

I'm fine with removing it or also maybe just removing collisions from ellipsoid and cone in that world if RTF performance is more desirable.

@azeey
Copy link
Contributor Author

azeey commented Jul 3, 2024

When I visualize the mesh, I see a lot of triangles for both the cone and ellipsoid. In shapes.sdf, the cone generates about 20 contact points and ellipsoid generates 1 until it falls over and then ~11 contact points. Would it be possible to limit the number of contact points when we construct the physics shapes? Maybe @iche033 knows

@iche033
Copy link
Contributor

iche033 commented Jul 3, 2024

with #2270, we can now set the max no. of contact points for all collision pairs in SDF. For dartsim, it comes down to the SetWorldCollisionPairMaxContacts function in gz-physics. However, we can not set the max contact point for each individual collision yet.

@azeey azeey moved this from Inbox to To do in Core development Jul 22, 2024
@bperseghetti
Copy link
Member

bperseghetti commented Jul 28, 2024

Looking to add cone directly supported in ODE->DART->Gazebo:
dartsim/dart#1805
https://bitbucket.org/odedevs/ode/issues/19/dcone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

3 participants