Merge pull request #434 from azeey/12_to_main

Merge gz-transport12 ➡️ main
gazebosim · Aug 30, 2023 · b2877bc · b2877bc
2 parents c507108 + 0f6392a
commit b2877bc
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/.github/workflows/triage.yml b/.github/workflows/triage.yml
@@ -10,10 +10,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Add ticket to inbox
-        uses: technote-space/create-project-card-action@v1
+        uses: actions/[email protected]
         with:
-          PROJECT: Core development
-          COLUMN: Inbox
-          GITHUB_TOKEN: ${{ secrets.TRIAGE_TOKEN }}
-          CHECK_ORG_PROJECT: true
+          project-url: https://github.com/orgs/gazebosim/projects/7
+          github-token: ${{ secrets.TRIAGE_TOKEN }}
 
diff --git a/parameters/src/Client_TEST.cc b/parameters/src/Client_TEST.cc
@@ -69,7 +69,7 @@ TEST_F(ParametersClientTest, Parameter)
     {
       std::unique_ptr<google::protobuf::Message> msg;
       EXPECT_TRUE(client.Parameter("parameter2", msg));
-      EXPECT_TRUE(msg);
+      ASSERT_NE(nullptr, msg);
       auto downcastedMsg = dynamic_cast<msgs::StringMsg *>(msg.get());
       EXPECT_EQ(downcastedMsg->data(), "");
     }

diff --git a/parameters/src/cmd/ParamCommandAPI_TEST.cc b/parameters/src/cmd/ParamCommandAPI_TEST.cc
@@ -101,15 +101,19 @@ TEST_F(ParametersClientTest, cmdParameterGet)
     cmdParameterGet("", "parameter1");
     auto output = coutCapture.str();
     EXPECT_NE(std::string::npos, output.find("gz_msgs.Boolean"));
-    EXPECT_EQ(cerrCapture.str(), "");
+    // TODO(azeey) Uncomment after
+    // https://github.com/gazebosim/gz-transport/issues/435 is resolved
+    // EXPECT_EQ(cerrCapture.str(), "");
   }
   {
     CaptureCoutScoped coutCapture;
     CaptureCerrScoped cerrCapture;
     cmdParameterGet("", "parameter2");
     auto output = coutCapture.str();
     EXPECT_NE(std::string::npos, output.find("gz_msgs.StringMsg"));
-    EXPECT_EQ(cerrCapture.str(), "");
+    // TODO(azeey) Uncomment after
+    // https://github.com/gazebosim/gz-transport/issues/435 is resolved
+    // EXPECT_EQ(cerrCapture.str(), "");
   }
   {
     CaptureCoutScoped coutCapture;
@@ -118,7 +122,9 @@ TEST_F(ParametersClientTest, cmdParameterGet)
     auto output = coutCapture.str();
     EXPECT_NE(std::string::npos, output.find("gz_msgs.StringMsg"));
     EXPECT_NE(std::string::npos, output.find("bsd"));
-    EXPECT_EQ(cerrCapture.str(), "");
+    // TODO(azeey) Uncomment after
+    // https://github.com/gazebosim/gz-transport/issues/435 is resolved
+    // EXPECT_EQ(cerrCapture.str(), "");
   }
   {
     CaptureCerrScoped cerrCapture;