Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11 ➡️ 12 - Disable playback.ReplayStep for windows (#517) #521

Merged
merged 1 commit into from
Aug 23, 2024
Merged

11 ➡️ 12 - Disable playback.ReplayStep for windows (#517) #521

merged 1 commit into from
Aug 23, 2024

Conversation

Crola1702
Copy link
Contributor

➡️ Forward port

Port ign-transport11 to gz-transport12

Follow up of #517, #518

Disables #195

Branch comparison: ign-transport12...ign-transport11

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@Crola1702 Crola1702 self-assigned this Aug 21, 2024
@Crola1702 Crola1702 requested a review from caguero as a code owner August 21, 2024 19:15
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 21, 2024
@Crola1702 Crola1702 requested review from azeey and Blast545 August 21, 2024 19:22
Blast545
Blast545 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you double check if the failing CI in homebrew is unrelated to this change?

@Crola1702
Copy link
Contributor Author

can you double check if the failing CI in homebrew is unrelated to this change?

Yes, error is #509, already reported

@Crola1702
Copy link
Contributor Author

@azeey @caguero can you help me merge this PR?

@azeey azeey merged commit d1dc8b2 into gz-transport12 Aug 23, 2024
9 of 10 checks passed
@azeey azeey deleted the Crola1702/11_to_12_2024-08-21 branch August 23, 2024 16:30
@Crola1702 Crola1702 mentioned this pull request Aug 23, 2024
Merged
@claraberendsen claraberendsen mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

@azeey azeey Awaiting requested review from azeey

Assignees

@Crola1702 Crola1702

Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Crola1702 @Blast545 @azeey