Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignition #100

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Remove ignition #100

merged 5 commits into from
Oct 12, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 27, 2023

🎉 New feature

Removes ignition

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig nkoenig requested a review from azeey as a code owner July 27, 2023 13:02
@nkoenig nkoenig marked this pull request as draft July 27, 2023 13:02
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #100 (e0ac328) into main (4a19b82) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   80.11%   80.11%           
=======================================
  Files           8        8           
  Lines         342      342           
=======================================
  Hits          274      274           
  Misses         68       68           
Files Coverage Δ
cli/include/gz/utils/cli/GzFormatter.hpp 88.88% <ø> (ø)

@azeey azeey marked this pull request as ready for review October 12, 2023 22:27
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@azeey azeey merged commit 32e4019 into main Oct 12, 2023
6 checks passed
@azeey azeey deleted the nkoenig/remove-ign branch October 12, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants