Add new functions for manipulating the environment #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds functions for using collections with the environment. It allows for conveniently retreiving and setting the environment variables via a map, rather than individually. This also adds a clearenv and printenv for completeness. Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-utils2 #114 +/- ##
==============================================
- Coverage 91.97% 79.67% -12.31%
==============================================
Files 6 8 +2
Lines 137 364 +227
==============================================
+ Hits 126 290 +164
- Misses 11 74 +63
|
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/environment_features
branch
from
faabbe0
to
65f81d7
Compare
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/environment_features
branch
from
f270fd2
to
55451cc
Compare
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/environment_features
branch
from
8b2a7d4
to
c0f0542
Compare
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/environment_features
branch
from
239ecb6
to
1756d83
Compare
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
|
Is the idea to eventually deprecate the env functions in gz-common and use these instead? |
Signed-off-by: Michael Carroll <[email protected]>
The gz-common ones are now just forwarding to the other env functions here. I added them because we have packages that we want env functionality in that don't depend on gz-common (eg sdformat). |
|
A couple of tests are failing on windows. |
Neat. So what this was is that |
Signed-off-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functions for using collections with the environment. It allows for conveniently retreiving and setting the environment variables via a map, rather than individually.
This also adds a clearenv and printenv for completeness.