Skip to content

Commit

Permalink
[EDR Workflows][Osquery][E2E] Unskip osquery packs_integration·cy·ts …
Browse files Browse the repository at this point in the history
…test (elastic#180457)

closes elastic#180424

The SuperSelect EUI component started showing an extra `<span/>` when it
displayed the selected value
([change](https://github.com/elastic/eui/blob/d08f49cf1f0ee6a31301ade914a2d06143d4a3d4/src/components/form/super_select/super_select_control.tsx#L195-L201)
from elastic/eui#7650) . This caused a problem
in a test that checks the agent policy name strictly. I changed the test
to see if the text `contains` the string instead of `has` it. I checked
the flow and found it doesn't affect the data sent to the API. Also, the
`euiScreenReaderOnly` property hides this extra span in the regular UI
so it is not visible to users.

![Screenshot 2024-04-10 at 12 47
31](https://github.com/elastic/kibana/assets/29123534/b7ff5b0e-5792-4bab-ac3a-61ba622c2c07)
  • Loading branch information
szwarckonrad authored Apr 11, 2024
1 parent 40da1dd commit 13c3da1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@ import { cleanupPack, cleanupAgentPolicy } from '../../tasks/api_fixtures';
import { request } from '../../tasks/common';
import { ServerlessRoleName } from '../../support/roles';

// FLAKY: https://github.com/elastic/kibana/issues/180424
// Failing: See https://github.com/elastic/kibana/issues/180424
describe.skip('ALL - Packs', { tags: ['@ess', '@serverless'] }, () => {
describe('ALL - Packs', { tags: ['@ess', '@serverless'] }, () => {
const integration = 'Osquery Manager';

describe(
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/osquery/cypress/tasks/integrations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const addIntegration = (agentPolicy = DEFAULT_POLICY) => {
cy.contains('Existing hosts').click();
cy.getBySel('agentPolicySelect').click();
cy.contains(agentPolicy).click();
cy.getBySel('agentPolicySelect').should('have.text', agentPolicy);
cy.getBySel('agentPolicySelect').should('contain.text', agentPolicy);
cy.getBySel(CREATE_PACKAGE_POLICY_SAVE_BTN).click();
// sometimes agent is assigned to default policy, sometimes not
closeModalIfVisible();
Expand Down

0 comments on commit 13c3da1

Please sign in to comment.